Upgrade Python version to 3.10 #811
Conversation
|
You missed my sneaky .gitlab-ci.yml test that references python:3.8 🐧 Aside: I can't leave a comment that isn't related to a diff in a review, right? Why not GitHub. |
dependencies/pip/requirements.in
Outdated
| lxml | ||
| pyxform==1.9.0 | ||
| django-reversion<3.0.2 | ||
| xlwt | ||
| openpyxl | ||
| celery>=4.0,<5.0 | ||
| celery>=5 |
There was a problem hiding this comment.
Is this any better than just celery? It's saying use celery >= 5. So 6 would match that too. Any pip-compile --upgrade would pick the newest compatible version, so maybe unnecessary to specify a minimum version. I'm new to pip-tools so maybe I'm missing something.
Personally I prefer the ^ and ~ syntax to tie things to major and minor versions. Then liberally upgrading patch versions via pip-compile --upgrade quite often to deliver security patches without major version changes.
There was a problem hiding this comment.
Actually, it did not want to upgrade to latest one on my environment. Indeed >=5 should not required to install the latest version.
I'll try again and change it if it works as expected.
noliveleger
force-pushed
the
upgrade-python-3.10
branch
2 times, most recently
from
e79f0c5
to
1fa30ad
Compare
noliveleger
force-pushed
the
upgrade-python-3.10
branch
from
1fa30ad
to
8b541b8
Compare
Description
Use Python 3.10 in docker image
Additional info
Changes:
Removed:
transifex-client. Only support 3.9 max. Support Python 3.10 issue. We use GitHub Actions to compile translations.nosePackages that cannot be upgraded now:
Related issues
kobotoolbox/kpi#3759